This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c

From: nick clifton <nickc at redhat dot com>
To: Pedro Alves <palves at redhat dot com>, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
Cc: "'asmwarrior'" <asmwarrior at gmail dot com>, "'GDB Development'" <gdb at sourceware dot org>, "'Binutils Development'" <binutils at sourceware dot org>
Date: Thu, 19 Dec 2013 11:12:30 +0000
Subject: Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c
Authentication-results: sourceware.org; auth=none
References: <52B17083 dot 7040404 at gmail dot com> <52B1738D dot 4010409 at redhat dot com> <52b19d19 dot 0850420a dot 7b6a dot 52dcSMTPIN_ADDED_BROKEN at mx dot google dot com> <52B1E1B0 dot 4040400 at redhat dot com>

Hi Pedro, Hi Pierre,

Pedro Alves wrote:

On 12/18/2013 01:02 PM, Pierre Muller wrote:

-#ifdef __CYGWIN__
+#if defined  __CYGWIN__ || defined __MINGW32__
+#ifdef __MINGW32__
+#define wcsncasecmp wcsnicmp
+#endif
    /* Under Cygwin unicode == UTF-16 == wchar_t.
       FIXME: The same is true for MingGW - we should test for that too.  */


Isn't this FIXME note stale now?

True - Pierre: would you mind removing the FIXME comment as well, whenyou check in your patch please ?


Cheers
  Nick

References:
- Re: BFD MinGW build error: implicit declaration of function 'wcsncasecmp'
  - From: Pedro Alves
- Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]