This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][gold] compiling gold with libc++ and __stl_hash_string
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Jan Voung <jvoung at google dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 18 Dec 2013 15:50:05 -0800
- Subject: Re: [PATCH][gold] compiling gold with libc++ and __stl_hash_string
- Authentication-results: sourceware.org; auth=none
- References: <CACfqt7g5oYp2KejMUGfzS_Fu8okKnAgp2jKJNJiH27xuo_t2iA at mail dot gmail dot com> <CAKOQZ8x3cLGAFtF8Jpns=oEcs3UED65091a4tp9r7OAN8N+3tg at mail dot gmail dot com> <CAHACq4p_7t=Zk0hv2z4DGXh78zZJeP5nhOZgsTJ1ExqkdaogKg at mail dot gmail dot com>
On Wed, Dec 18, 2013 at 3:25 PM, Cary Coutant <ccoutant@google.com> wrote:
>> That's not the right fix. That code should only be used if gold is
>> using <ext/hash_map>, which is a fall back for older compilers.
>> Currently gold prefers <tr1/unordered_map>. I think we need to add a
>> case to configure.ac and system.h to use <unordered_map> if it is
>> available, as I assume it is for libc++.
>
> Ian, does the attached patch look OK?
Yes, that looks good. Thanks.
> Would we want to turn on C++11 at some point? I believe we get
> <unordered_map> in G++ if we turn on --std=c++11.
At some point, sure. But we need to make it easy to build gold with
older compilers, so probably not any time soon.
Ian