This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi, Nick Thanks for your review and comment. I have updated this patch as follows: 1. Add nds32 specification into document. 2. Add testsuite gas/testsuite/gas/nds32. 3. Announce nds32 support. 4. Replace all PTR uses. Please find the attached file. 2013/12/6 nick clifton <nickc@redhat.com>: > Hi Kuan-Lin, > > There are a few problems with this patch: > > 1. There is no addition to the assembler documentation. > > I would like to see a gas/doc/c-nds32.texi file which includes > documentation for the NDS32 specific command line options, pseudo-ops > and synthetic instructions. > > > 2. There is no testsuite. > > There ought to be a gas/testsuite/gas/nds32 directory containing at > least one test, (but preferably a lot more), that checks the assembly of > NDS32 instructions. > > > 3. There is no NEWS announcement. > > The file gas/NEWS should be patched to include a sentance announcing > the additon of support for the NDS32. > > > 4. The use of the PTR macro is deprecated. > > Please replace all uses of the PTR macro with "void *". > > > Cheers > Nick > -- Best regards, Kuan-Lin Chen. kuanlinchentw@gmail.com
Attachment:
binutils-3-gas.patch
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |