This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND


On Sun, Nov 17, 2013 at 10:35 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> +if DEFAULT_TARGET_X86_64
> +check_PROGRAMS += exception_x86_64_bnd_test
> +exception_x86_64_bnd_test_SOURCES = exception_test_main.cc
> +exception_x86_64_bnd_test_DEPENDENCIES = exception_x86_64_bnd_1.o \
> +                                        exception_x86_64_bnd_2.o
> +exception_x86_64_bnd_test_LDFLAGS = $(exception_test_LDFLAGS)
> +exception_x86_64_bnd_test_LDADD = $(exception_x86_64_bnd_test_DEPENDENCIES)
> +exception_x86_64_bnd_1.o: exception_test_1.cc
> +       $(CXXCOMPILE) -c -fpic -Bgcctestdir/ -Wa,-madd-bnd-prefix -o $@ >lt;
> +exception_x86_64_bnd_2.o: exception_test_2.cc
> +       $(CXXCOMPILE) -c -Bgcctestdir/ -Wa,-madd-bnd-prefix -o $@ >lt;
> +endif DEFAULT_TARGET_X86_64

The -madd-bnd-prefix option only works with a very recent assembler.
These last two rules should have gcctestdir/as as a dependency so that
the compiles will pick up the in-tree assembler. Alternatively, we
could add a configure check for the -madd-bnd-prefix option, and make
this test case conditional. I'd prefer the former -- your thoughts?

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]