This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, i386] Support of SHA ISA extension
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, areg dot melikadamyan at gmail dot com
- Date: Wed, 24 Jul 2013 09:08:36 -0700
- Subject: Re: [PATCH, i386] Support of SHA ISA extension
- References: <51EFCDD3 dot 9060403 at gmail dot com>
On Wed, Jul 24, 2013 at 5:51 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
> Attached patch introduces support of Intel SHA ISA extensions. See [1].
>
> Testing pass.
>
> Ok to install?
>
> gas/Changelog:
> 2013-07-24 Michael Zolotukhin <michael.v.zolotukhin@intel.com> <mailto:michael.v.zolotukhin@intel.com>
>
> * config/tc-i386.c (cpu_arch): Add SHA.
It should be "Add .sha".
> * doc/c-i386.texi: Document new option.
It should be "Document sha/.sha".
>
> gas/testsuite/Changelog:
> 2013-07-24 Michael Zolotukhin <michael.v.zolotukhin@intel.com> <mailto:michael.v.zolotukhin@intel.com>
>
> * gas/i386/sha.d: New.
> * gas/i386/sha.s: New.
> * gas/i386/x86-64-sha.d: New.
> * gas/i386/x86-64-sha.s: New.
> * gas/i386/i386.exp: Add new tests.
It should be "Run new SHA tests".
> opcodes/Changelog:
> 2013-07-24 Michael Zolotukhin <michael.v.zolotukhin@intel.com> <mailto:michael.v.zolotukhin@intel.com>
>
> * i386-dis.c (PREFIX enum): Add new entries.
Please list the new PREFIX_XXX. Please also update MPX
ChangeLog entries in opcodes to list new MOD_XXX and PREFIX_XXX.
> (prefix_table): Add new entries.
> (three_byte_table): Likewise.
> * i386-gen.c (cpu_flag_init): Add CpuSHA.
> (cpu_flags): Add CpuSHA.
> (CpuUnused): Comment out.
> (i386_cpu_flags): Add cpusha.
> * i386-init.h: Regenerate.
> * i386-opc.h (CpuSHA): New.
> * i386-opc.tbl: Add SHA instructions.
> * i386-tbl.h: Regenerate.
>
This patch no longer applies after MPX support is checked
into mainline. Please provide a new patch.
Thanks.
--
H.J.