This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/5] New target port: Andes 'nds32'. (bfd)

From: Kuan-Lin Chen <kuanlinchentw at gmail dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>, binutils at sourceware dot org
Date: Fri, 12 Jul 2013 11:00:54 +0800
Subject: Re: [PATCH 1/5] New target port: Andes 'nds32'. (bfd)
References: <CAJr6u0h4WK8BHp1+N1E9WKeBuX+5nFVWrprKDEHMu14EL2tPAw at mail dot gmail dot com> <Pine dot LNX dot 4 dot 64 dot 1307091559010 dot 23421 at digraph dot polyomino dot org dot uk>

Hi, Joseph

I've fix the first patch according to your suggestions.
Attached please find the revised version.

1. Licence notices is changed to GPLv3.
2. FSF postal address is modified to be right.
3. Add static/const  for array/variables if possible.
4. Remove all global variables and pass these target options by the structure.
5. Remove the comment "FIXME: This should not be a static variable.", because
this variable should be static. It is a wrong comment.

BTW, nds32_insertion_sort uses alloca for constant size Elf_Internal_Rela,
and only once in each function call.  Therefore, I think this is safe to use
alloca here.  If I am wrong, please feel free to correct me. Thanks.

Thank you again for your time to review.

-- 
Best regards,
Kuan-Lin Chen.
kuanlinchentw@gmail.com

Attachment: binutils-1-bfd.patch.tar.bz2
Description: BZip2 compressed data

References:
- [PATCH 1/5] New target port: Andes 'nds32'. (bfd)
  - From: Kuan-Lin Chen
- Re: [PATCH 1/5] New target port: Andes 'nds32'. (bfd)
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]