This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCHv2, ARM] Fix handling of GOT and PLT access to IFUNC symbols
- From: Tristan Gingold <gingold at adacore dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Patch Tracking <patches at linaro dot org>, rdsandiford at googlemail dot com, Tristan Gingold <gingold at adacore dot com>
- Date: Tue, 28 May 2013 15:43:51 +0200
- Subject: Re: [PATCHv2, ARM] Fix handling of GOT and PLT access to IFUNC symbols
- References: <5177A5BF dot 8080406 at linaro dot org> <87ip39d5w7 dot fsf at sandifor-thinkpad dot stglab dot manchester dot uk dot ibm dot com> <CANu=Dmj5ZAH4cQ7-MDgShWdfM2PFFmpwneftDQ5hDULsGrpAGw at mail dot gmail dot com> <CANu=Dmh4AXyyMws0Wj_JrJTKFE0XFvhFBtKEzUkEne2jb9U=eA at mail dot gmail dot com> <CANu=Dmhrzkabjb0JF96pOZG=CZS8qhv8uOJBsceDQ=z7wD7Tng at mail dot gmail dot com>
On May 28, 2013, at 9:50 AM, Will Newton <will.newton@linaro.org> wrote:
> On 29 April 2013 15:36, Will Newton <will.newton@linaro.org> wrote:
>> On 29 April 2013 10:51, Will Newton <will.newton@linaro.org> wrote:
>>> On 26 April 2013 09:59, Richard Sandiford <rdsandiford@googlemail.com> wrote:
>>>> Will Newton <will.newton@linaro.org> writes:
>>>>> bfd/ChangeLog:
>>>>>
>>>>> 2013-04-24 Will Newton <will.newton@linaro.org>
>>>>>
>>>>> * elf32-arm.c (elf32_arm_populate_plt_entry): Call
>>>>> elf32_arm_add_dynreloc when emitting R_ARM_IRELATIVE relocs.
>>>>>
>>>>> ld/testsuite/ChangeLog:
>>>>>
>>>>> 2013-04-24 Will Newton <will.newton@linaro.org>
>>>>>
>>>>> * ld-arm/arm-elf.exp: Add IFUNC test 17.
>>>>> * ld-arm/ifunc-17.dd: New file.
>>>>> * ld-arm/ifunc-17.gd: Likewise.
>>>>> * ld-arm/ifunc-17.rd: Likewise.
>>>>> * ld-arm/ifunc-17.s: Likweise.
>>>>> * ld-arm/ifunc-1.rd: Reorder relocs to match linker output.
>>>>> * ld-arm/ifunc-2.rd: Likewise.
>>>>> * ld-arm/ifunc-5.rd: Likewise.
>>>>> * ld-arm/ifunc-6.rd: Likewise.
>>>>
>>>> Looks good, thanks. OK if no ARM maintainer objects in 48 hours.
>>>
>>> Thanks, applied.
>>
>> Tristan, is this ok for the 2.23 branch?
>
> Ping?
>
> Is this patch (and the follow-up that fixes the arm-eabi testsuite
> failure) ok for the 2.23 branch?
Yes, this is OK for 2.23 (although I am not sure there will be a new 2.23 release)
Tristan.