This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: Add --rosegment-gap option
- From: Cary Coutant <ccoutant at google dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Derek Schuff <dschuff at google dot com>
- Date: Fri, 10 May 2013 14:05:01 -0700
- Subject: Re: [PATCH] gold: Add --rosegment-gap option
- References: <CAB=4xhpSj1o-cMBD+S7e5b0SrQLFQ1q1==wHQ+xUbiZi-JbV3w at mail dot gmail dot com>
> 2013-05-10 Roland McGrath <mcgrathr@google.com>
>
> * options.h (General_options): Add --rosegment-gap option.
> * options.cc (finalize): --rosegment-gap implies --rosegment.
> * layout.cc (set_segment_offsets): Let user option override
> target->rosegment_gap().
> + uint64_t gap = target->rosegment_gap();
> + if (parameters->options().user_set_rosegment_gap())
> + gap = parameters->options().rosegment_gap();
No need to call target->rosegment_gap() if user_set_rosegment_gap() is
true. Move that call to an else clause.
OK with that change.
-cary