This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Committed, bfd/mmo.c (mmo_write_chunk): break out expression.
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: binutils at sourceware dot org
- Date: Sun, 14 Apr 2013 11:01:02 -0400 (EDT)
- Subject: Committed, bfd/mmo.c (mmo_write_chunk): break out expression.
A trivial simplifying-replacing source-code change without observable
execution effect. Committed after testing mmix-knuth-mmixware, nevertheless.
* mmo.c (mmo_write_chunk): Break out abfd->tdata.mmo_data to new
local variable mmop.
Index: mmo.c
===================================================================
RCS file: /cvs/src/src/bfd/mmo.c,v
retrieving revision 1.45
diff -p -u -r1.45 mmo.c
--- mmo.c 26 Jan 2013 02:08:01 -0000 1.45
+++ mmo.c 14 Apr 2013 14:46:40 -0000
@@ -787,21 +787,21 @@ static INLINE bfd_boolean
mmo_write_chunk (bfd *abfd, const bfd_byte *loc, unsigned int len)
{
bfd_boolean retval = TRUE;
+ struct mmo_data_struct *mmop = abfd->tdata.mmo_data;
/* Fill up a tetra from bytes remaining from a previous chunk. */
- if (abfd->tdata.mmo_data->byte_no != 0)
+ if (mmop->byte_no != 0)
{
- while (abfd->tdata.mmo_data->byte_no < 4 && len != 0)
+ while (mmop->byte_no < 4 && len != 0)
{
- abfd->tdata.mmo_data->buf[abfd->tdata.mmo_data->byte_no++] = *loc++;
+ mmop->buf[mmop->byte_no++] = *loc++;
len--;
}
- if (abfd->tdata.mmo_data->byte_no == 4)
+ if (mmop->byte_no == 4)
{
- mmo_write_tetra (abfd,
- bfd_get_32 (abfd, abfd->tdata.mmo_data->buf));
- abfd->tdata.mmo_data->byte_no = 0;
+ mmo_write_tetra (abfd, bfd_get_32 (abfd, mmop->buf));
+ mmop->byte_no = 0;
}
}
@@ -811,7 +811,7 @@ mmo_write_chunk (bfd *abfd, const bfd_by
mmo_write_tetra_raw (abfd, LOP_QUOTE_NEXT);
retval = (retval
- && ! abfd->tdata.mmo_data->have_error
+ && ! mmop->have_error
&& 4 == bfd_bwrite (loc, 4, abfd));
loc += 4;
@@ -820,12 +820,12 @@ mmo_write_chunk (bfd *abfd, const bfd_by
if (len)
{
- memcpy (abfd->tdata.mmo_data->buf, loc, len);
- abfd->tdata.mmo_data->byte_no = len;
+ memcpy (mmop->buf, loc, len);
+ mmop->byte_no = len;
}
if (! retval)
- abfd->tdata.mmo_data->have_error = TRUE;
+ mmop->have_error = TRUE;
return retval;
}
brgds, H-P