This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch, AARCH64] gc-section tests for PLT related relocations
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Venkataramanan Kumar <venkataramanan dot kumar at linaro dot org>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Patch Tracking <patch at linaro dot org>
- Date: Mon, 8 Apr 2013 12:44:27 +0100
- Subject: Re: [Patch, AARCH64] gc-section tests for PLT related relocations
- References: <CAJK_mQ00=2AOBRj29eQTuJkfenH-qPxaOuU5_7N3b0v4-tWcRQ at mail dot gmail dot com>
Hi, Couple of comments....
diff -urN src-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d
src-plt-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d
--- src-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d 1970-01-01
05:30:00.000000000 +0530
+++ src-plt-tls/ld/testsuite/ld-aarch64/gc-plt-relocs.d 2013-04-03
11:50:02.562593137 +0530
@@ -0,0 +1,48 @@
+#source: gc-plt1.s
+#source: gc-plt-main.s
+#source: gc-plt-hidden.s
+#source: gc-plt2.s
+#ld: --gc-sections -T aarch64.ld --shared
+#objdump: -dT
+
+# Shared object with plt related relocs against global symbol
+# and local functions gced. After gc-section removal we are
Double space after period (GNU coding style).
+# checking that function does not exit
exit -> exists.
+
+.*: file format elf64-littleaarch64
This also needs to handle BE.
Cheers
/Marcus
On 3 April 2013 08:20, Venkataramanan Kumar
<venkataramanan.kumar@linaro.org> wrote:
> Hi Maintainers,
>
> This patch adds gc-section tests for PLT related aarch64 relocations
> on top of the TLS and GOT tests that I posted last week.
>
> These additional tests are passing with make check for aarch64-none-linux-gnu.
>
> No regressions.
>
> The patch that covers TLS and GOT can be found here:
> http://sourceware.org/ml/binutils/2013-03/msg00273.html
>
> If it is Ok for trunk, please commit on my behalf?
>
> regards,
> Venkat.