This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Fix error handling for pc-relative VSTR in Thumb mode.

From: Ramana Radhakrishnan <ramrad01 at arm dot com>
To: Will Newton <will dot newton at linaro dot org>
Cc: binutils at sourceware dot org
Date: Mon, 11 Mar 2013 15:56:04 +0000
Subject: Re: [PATCH, ARM] Fix error handling for pc-relative VSTR in Thumb mode.
References: <51373BB8.1080409@linaro.org>
Reply-to: ramrad01 at arm dot com

diff --git a/gas/testsuite/gas/arm/neon-addressing-bad.s b/gas/testsuite/gas/arm/neon-addressing-bad.s
index c134ead..773ec43 100644
--- a/gas/testsuite/gas/arm/neon-addressing-bad.s
+++ b/gas/testsuite/gas/arm/neon-addressing-bad.s
@@ -21,3 +21,5 @@ VST1.8 {D0}, R0
  VST1.8 {Q1}, R0
  VST1.8 {D0}, [PC]
  VST1.8 {D0}, [PC, #0]
+VSTR D0, [PC]
+VSTR D0, [PC, #0]

For bonus points (though I'm no maintainer), it would be nice for the disassembler to print out UNPREDICTABLE on disassembling such instructions. See what Kyryll did recently with the crc instructions as an example and other existing practice in the disassembler.

You can create testcases using the .inst directives.


regards,
Ramana

References:
- [PATCH, ARM] Fix error handling for pc-relative VSTR in Thumb mode.
  - From: Will Newton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]