This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: patch r5900/micromips handling
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: JÃrgen Urban <JuergenUrban at gmx dot de>
- Cc: binutils at sourceware dot org
- Date: Tue, 29 Jan 2013 21:08:39 +0000
- Subject: Re: patch r5900/micromips handling
- References: <20130127223320.288520@gmx.net>
Looks good, thanks. Just a couple of minor things:
"JÃrgen Urban" <JuergenUrban@gmx.de> writes:
> +/* True, if CPU has support for ldc1 and sdc1. */
> +#define CPU_HAS_LDC1_SDC1(CPU) ((mips_opts.isa != ISA_MIPS1) && ((CPU) != CPU_R5900))
> +
Formatting, should be:
#define CPU_HAS_LDC1_SDC1(CPU) \
(mips_opts.isa != ISA_MIPS1 && (CPU) != CPU_R5900)
> /* True if mflo and mfhi can be immediately followed by instructions
> which write to the HI and LO registers.
>
> @@ -9027,8 +9030,7 @@ macro (struct mips_cl_insn *ip)
> s = segment_name (S_GET_SEGMENT (offset_expr.X_add_symbol));
> if (strcmp (s, ".lit8") == 0)
> {
> - if ((mips_opts.isa != ISA_MIPS1 || mips_opts.micromips)
> - && (mips_opts.arch != CPU_R5900))
> + if (CPU_HAS_LDC1_SDC1(mips_opts.arch) || mips_opts.micromips)
Missing space before "(". A few other cases.
> diff -Nurp binutils-cvs-20130104/gas/testsuite/gas/mips/24k-triple-stores-2.s binutils-cvs-20130104-mips64el-linux-patched/gas/testsuite/gas/mips/24k-triple-stores-2.s
> --- binutils-cvs-20130104/gas/testsuite/gas/mips/24k-triple-stores-2.s 2013-01-26 18:28:08.503235967 +0100
> +++ binutils-cvs-20130104-mips64el-linux-patched/gas/testsuite/gas/mips/24k-triple-stores-2.s 2013-01-26 21:08:44.343223485 +0100
> @@ -28,12 +28,6 @@ foo:
> swl $6,0($sp)
> break
>
> - sc $2,32($sp)
> - sc $3,8($sp)
> - sc $4,-8($sp)
> - sc $5,0($sp)
> - sc $6,32($sp)
> -
Please remove the last "break" too, since it was there to separate
groups of stores.
Richard