This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH/RFC 02/02 v2] Refactor PRPSINFO handling on GDB
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, GDB Patches <gdb-patches at sourceware dot org>, Binutils Development <binutils at sourceware dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Fri, 11 Jan 2013 01:53:36 -0200
- Subject: Re: [PATCH/RFC 02/02 v2] Refactor PRPSINFO handling on GDB
- References: <m3ip81v0fu.fsf@redhat.com> <20121218171555.GA19639@host2.jankratochvil.net> <m3pq1ykp6j.fsf@redhat.com> <m38v8gfgq9.fsf@redhat.com> <20121231194134.GA17955@host2.jankratochvil.net> <m3623d7e6l.fsf@redhat.com> <50EF0BE3.6040503@redhat.com>
On Thursday, January 10 2013, Pedro Alves wrote:
> The subject is a bit misleading, as this does more than
> just refactoring PRPSINFO handling; it dumps more fields
> as well. Splitting the refactoring and the actual
> extending into separate patches, along with a short
> description of what's new in the cores would have been neat,
> but I'm coming back late to the party, and don't insist.
Wow, OK, sorry about that, it wasn't my intention.
Anyway, at first I thought that the extension could be seen as
refactoring as well, that's why I didn't bother making another patch.
>> + /* Generating and copying the program's arguments. `get_inferior_args'
>> + may throw, but we want to continue the execution anyway. */
>> + TRY_CATCH (ex, RETURN_MASK_ERROR)
>> + {
>> + infargs = get_inferior_args ();
>> + }
>> +
>
> Hmm? We were not doing that before. What exception is that?
`get_inferior_args' calls `construct_inferior_arguments', which can call
`error' in an specific scenario (not STARTUP_WITH_SHELL, arguments that
contain spaces).
--
Sergio