This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RFA: rename std_section
- From: Tom Tromey <tromey at redhat dot com>
- To: Binutils Development <binutils at sourceware dot org>
- Date: Wed, 02 Jan 2013 08:57:17 -0700
- Subject: RFA: rename std_section
While researching another patch, I stumbled across the 'std_section'
global.
I think it would be better if BFD used a name prefix everywhere, so this
patch prepends "_bfd_".
Ok?
I tested this by rebuilding gdb and binutils with the patch applied.
I did have to 'make clean' in 'ld'; I suppose some dependencies are
missing. Why doesn't binutils use the automake dependency-tracking
scheme? It is one of the nice benefits of using automake.
Tom
* section.c (_bfd_std_section): Rename from std_section.
(bfd_com_section_ptr, bfd_und_section_ptr, bfd_abs_section_ptr)
(STD_SECTION): Update.
* bfd-in2.h: Rebuild.
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 82537c1..ceacf8f 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -1575,7 +1575,7 @@ struct relax_table {
/* These sections are global, and are managed by BFD. The application
and target back end are not permitted to change the values in
these sections. */
-extern asection std_section[4];
+extern asection _bfd_std_section[4];
#define BFD_ABS_SECTION_NAME "*ABS*"
#define BFD_UND_SECTION_NAME "*UND*"
@@ -1583,13 +1583,13 @@ extern asection std_section[4];
#define BFD_IND_SECTION_NAME "*IND*"
/* Pointer to the common section. */
-#define bfd_com_section_ptr (&std_section[0])
+#define bfd_com_section_ptr (&_bfd_std_section[0])
/* Pointer to the undefined section. */
-#define bfd_und_section_ptr (&std_section[1])
+#define bfd_und_section_ptr (&_bfd_std_section[1])
/* Pointer to the absolute section. */
-#define bfd_abs_section_ptr (&std_section[2])
+#define bfd_abs_section_ptr (&_bfd_std_section[2])
/* Pointer to the indirect section. */
-#define bfd_ind_section_ptr (&std_section[3])
+#define bfd_ind_section_ptr (&_bfd_std_section[3])
#define bfd_is_und_section(sec) ((sec) == bfd_und_section_ptr)
#define bfd_is_abs_section(sec) ((sec) == bfd_abs_section_ptr)
diff --git a/bfd/section.c b/bfd/section.c
index 6fd7d8e..a59bc71 100644
--- a/bfd/section.c
+++ b/bfd/section.c
@@ -1,7 +1,7 @@
/* Object file "section" support for the BFD library.
Copyright 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011,
- 2012
+ 2012, 2013
Free Software Foundation, Inc.
Written by Cygnus Support.
@@ -545,7 +545,7 @@ CODE_FRAGMENT
.{* These sections are global, and are managed by BFD. The application
. and target back end are not permitted to change the values in
. these sections. *}
-.extern asection std_section[4];
+.extern asection _bfd_std_section[4];
.
.#define BFD_ABS_SECTION_NAME "*ABS*"
.#define BFD_UND_SECTION_NAME "*UND*"
@@ -553,13 +553,13 @@ CODE_FRAGMENT
.#define BFD_IND_SECTION_NAME "*IND*"
.
.{* Pointer to the common section. *}
-.#define bfd_com_section_ptr (&std_section[0])
+.#define bfd_com_section_ptr (&_bfd_std_section[0])
.{* Pointer to the undefined section. *}
-.#define bfd_und_section_ptr (&std_section[1])
+.#define bfd_und_section_ptr (&_bfd_std_section[1])
.{* Pointer to the absolute section. *}
-.#define bfd_abs_section_ptr (&std_section[2])
+.#define bfd_abs_section_ptr (&_bfd_std_section[2])
.{* Pointer to the indirect section. *}
-.#define bfd_ind_section_ptr (&std_section[3])
+.#define bfd_ind_section_ptr (&_bfd_std_section[3])
.
.#define bfd_is_und_section(sec) ((sec) == bfd_und_section_ptr)
.#define bfd_is_abs_section(sec) ((sec) == bfd_abs_section_ptr)
@@ -725,9 +725,9 @@ static const asymbol global_syms[] =
};
#define STD_SECTION(NAME, IDX, FLAGS) \
- BFD_FAKE_SECTION(std_section[IDX], FLAGS, &global_syms[IDX], NAME, IDX)
+ BFD_FAKE_SECTION(_bfd_std_section[IDX], FLAGS, &global_syms[IDX], NAME, IDX)
-asection std_section[] = {
+asection _bfd_std_section[] = {
STD_SECTION (BFD_COM_SECTION_NAME, 0, SEC_IS_COMMON),
STD_SECTION (BFD_UND_SECTION_NAME, 1, 0),
STD_SECTION (BFD_ABS_SECTION_NAME, 2, 0),
--
1.7.7.6