This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: Add a testcase for PR binutils/14481
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 24 Oct 2012 04:28:59 -0700
- Subject: Re: PATCH: Add a testcase for PR binutils/14481
- References: <20120816203255.GA23224@intel.com> <87a9vmzbyb.fsf@schwinge.name>
On Tue, Oct 16, 2012 at 8:14 AM, Thomas Schwinge
<thomas@codesourcery.com> wrote:
> Hi!
>
> On Thu, 16 Aug 2012 13:32:55 -0700, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>> I checkec in this patch to add a testcase for PR binutils/14481.
>
>> --- a/binutils/ChangeLog
>> +++ b/binutils/ChangeLog
>> @@ -1,3 +1,14 @@
>> +2012-08-16 H.J. Lu <hongjiu.lu@intel.com>
>> +
>> + PR binutils/14481
>> + * Makefile.am (BFDTEST1_PROG): New.
>> + (TEST_PROGS): Likewise.
>> + (bfdtest1_DEPENDENCIES): Likewise.
>> + (noinst_PROGRAMS): Add $(TEST_PROGS).
>> + * Makefile.in: Regenerated.
>> +
>> + * bfdtest1.c: New file.
>> +
>
>> --- a/binutils/testsuite/ChangeLog
>> +++ b/binutils/testsuite/ChangeLog
>> @@ -1,3 +1,11 @@
>> +2012-08-16 H.J. Lu <hongjiu.lu@intel.com>
>> +
>> + PR binutils/14481
>> + * ar.exp (bfdtest1): New.
>> + (long_filenames): Run bfdtest1.
>> + (thin_archive): Likewise.
>> + (thin_archive_with_nested): Likewise.
>
>> diff --git a/binutils/testsuite/binutils-all/ar.exp b/binutils/testsuite/binutils-all/ar.exp
>> index 0caa847..c66c43e 100644
>> --- a/binutils/testsuite/binutils-all/ar.exp
>> +++ b/binutils/testsuite/binutils-all/ar.exp
>> @@ -27,6 +27,8 @@ if ![is_remote host] {
>> }
>> }
>>
>> +set bfdtest1 [findfile $base_dir/bfdtest1]
>
> This is not correct for cross-testing on a Windows host, and results in a
> bunch of ERRORs about the file not being found. Here is a patch -- OK to
> commit?
diff --git a/binutils/testsuite/binutils-all/ar.exp b/binutils/testsuite/binutil
s-all/ar.exp
index 05cc261..8b7629e 100644
--- a/binutils/testsuite/binutils-all/ar.exp
+++ b/binutils/testsuite/binutils-all/ar.exp
@@ -27,7 +27,7 @@ if ![is_remote host] {
}
}
-set bfdtest1 [findfile $base_dir/bfdtest1]
+set bfdtest1 $base_dir/bfdtest1
# send_user "Version [binutil_version $AR]"
Can you try this instead?
--
H.J.