This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/5] remove deleted BFDs from the archive cache


On Fri, Aug 17, 2012 at 7:55 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Alan" == Alan Modra <amodra@gmail.com> writes:
>
>>> * opncls.c (_bfd_delete_bfd): Check to see if section htab is
>>> already freed.
>
> Alan> This part can be committed now if you like.
>
> The issue was double-freeing of section_htab.  Because _bfd_delete_bfd
> checks abfd->memory before freeing the section_htab, and because
> _bfd_free_cached_info still calls objalloc_free, there's no need to do
> this check.
>

Agreed.

BTW, we still have a memory leak with bfd_zmalloc.  But I don't know
how serious it is.


--
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]