This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR ld/13909: PR ld/12570 causes eh_frame_hdr section to be sometimes too large


On Tue, May 22, 2012 at 8:10 AM, Alan Modra <amodra@gmail.com> wrote:
> On Tue, May 22, 2012 at 07:11:09AM -0700, H.J. Lu wrote:
>>
>> ? ?if (!info->no_ld_generated_unwind_info
>> ? ? ? ?&& htab->plt_eh_frame == NULL
>> - ? ? ?&& htab->elf.splt != NULL)
>> + ? ? ?&& htab->elf.splt != NULL
>> + ? ? ?&& bfd_get_section_by_name (dynobj, ".eh_frame") != NULL)
>
> Doesn't look correct to me. ?dynobj is one of the input files, usually
> the first one. ?Why should creating plt eh_frame info depend on one
> file?
>

I am reverting it now.

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]