This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] gas: Make dwarf2dbg.c versions specific and add DW_AT_high_pc case for DWARF 4+.


On Fri, 2012-04-27 at 14:28 +0200, Tristan Gingold wrote:
> > +/* The .debug_aranges version has been 2 in DWARF version 2, 3 and 4. */
> > +#define DWARF2_ARANGES_VERSION 2
> > +
> > +/* This implementation output version 2 .debug_line information. */
> > +#define DWARF2_LINE_VERSION 2
> 
> Please, wrap DWARF2_LINE_VERSION within #ifndef/#endif, so that a
> target can override it.  In particular on ia64/VMS, the backtrace
> symbolizer requires version 3.

OK can do. Do you know which version it wants set to 3?
info, aranges or line?

The trouble with the current code is that info, line and aranges all use
the same version number. But for aranges only 2 is a valid version and
the code does output only version 2 line info. Though it might be valid
to claim version 3 since the header length shows there is not really
more info than with version 2. But version 4 line info is really
different from earlier versions (readers will not be able to read it if
we set the version to 4).

Thanks,

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]