This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] m68k: fix weak undefined PIE tests


On Mon, Apr 23, 2012 at 08:04:40PM +0200, Andreas Schwab wrote:
> 	* elf32-m68k.c (elf_m68k_check_relocs): Mark non-GOT references
> 	also when generating PIE.
> 	(elf_m68k_discard_copies): Mark undefined weak symbols referenced
> 	by relocations as dynamic.

Looks reasonable, except

> -	      if (!info->shared)
> +	      if (!info->shared || info->executable)

this should just be "if (info->executable)".  !shared is redundant.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]