This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fix ColdFire movem with disp16+reg addressing
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 25 Apr 2012 11:14:30 +0200
- Subject: Re: [PATCH] Fix ColdFire movem with disp16+reg addressing
- References: <20111018111205.448d0942@rex.config> <4EA588FD.40004@redhat.com> <4F914014.8040505@embedded-brains.de> <259E7F86-47CC-42CB-8312-5FD269D6DD8B@adacore.com>
On 04/23/2012 08:54 AM, Tristan Gingold wrote:
On Apr 20, 2012, at 12:53 PM, Sebastian Huber wrote:
On 10/24/2011 05:49 PM, Nick Clifton wrote:
Hi Julian,
opcodes/
* m68k-opc.c (m68k_opcodes): Fix entries for ColdFire moveml.
gas/testsuite/
* gas/m68k/all.exp (movem-offset): Add test.
* gas/m68k/movem-offset.s: New test.
* gas/m68k/movem-offset.d: New.
Approved - please apply.
This is not in the 2.22 Binutils release. Is it possible to include this in a potential 2.22.1 release?
Yes, you can backport it.
I am currently not sure there will be a 2.22.1 release, however.
Tristan.
Please have a look at the attached patch. Without it Binutils 2.22 + Codefire
== No.
--
Sebastian Huber, embedded brains GmbH
Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone : +49 89 18 90 80 79-6
Fax : +49 89 18 90 80 79-9
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 0631572..dcd935d 100644
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -19,6 +19,12 @@
* gas/ppc/power6.s: Fix lfdpx first operand.
* gas/ppc/power6.d: Adjust expected output.
+2011-10-24 Julian Brown <julian@codesourcery.com>
+
+ * gas/m68k/all.exp (movem-offset): Add test.
+ * gas/m68k/movem-offset.s: New test.
+ * gas/m68k/movem-offset.d: New.
+
2011-09-21 David S. Miller <davem@davemloft.net>
* gas/sparc/hpcvis3.s: Update for fixed fchksum16 mnemonic.
diff --git a/gas/testsuite/gas/m68k/all.exp b/gas/testsuite/gas/m68k/all.exp
index bf06d4e..6035286 100644
--- a/gas/testsuite/gas/m68k/all.exp
+++ b/gas/testsuite/gas/m68k/all.exp
@@ -52,6 +52,8 @@ if { [istarget m68*-*-*] || [istarget fido*-*-*] } then {
run_dump_test mcf-movsr
run_dump_test mode5
run_dump_test mode5 "{name {cf}} {as {-mcpu=5200}}"
+ run_dump_test movem-offset
+ run_dump_test movem-offset "{name {cf}} {as {-mcpu=5485}}"
run_dump_test mcf-mac
run_dump_test mcf-emac
run_dump_test mcf-coproc
diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index a445030..8ecd310 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -18,6 +18,10 @@
mark them as invalid on POWER7. Use FRTp, FRAp, and FRBp repsectively
on DFP quad instructions.
+2011-10-24 Julian Brown <julian@codesourcery.com>
+
+ * m68k-opc.c (m68k_opcodes): Fix entries for ColdFire moveml.
+
2011-09-21 David S. Miller <davem@davemloft.net>
* sparc-opc.c (sparc_opcodes): Annotate table with HWCAP flag
diff --git a/opcodes/m68k-opc.c b/opcodes/m68k-opc.c
index 9463668..3c8310a 100644
--- a/opcodes/m68k-opc.c
+++ b/opcodes/m68k-opc.c
@@ -1553,10 +1553,10 @@ const struct m68k_opcode m68k_opcodes[] =
{"moveml", 4, one(0044300), one(0177700), "#w>s", m68000up },
{"moveml", 4, one(0046300), one(0177700), "<sLw", m68000up },
{"moveml", 4, one(0046300), one(0177700), "<s#w", m68000up },
-{"moveml", 4, one(0044320), one(0177770), "Lwys", mcfisa_a },
-{"moveml", 4, one(0044320), one(0177770), "#wys", mcfisa_a },
-{"moveml", 4, one(0046320), one(0177770), "ysLw", mcfisa_a },
-{"moveml", 4, one(0046320), one(0177770), "ys#w", mcfisa_a },
+{"moveml", 4, one(0044300), one(0177700), "Lwys", mcfisa_a },
+{"moveml", 4, one(0044300), one(0177700), "#wys", mcfisa_a },
+{"moveml", 4, one(0046300), one(0177700), "ysLw", mcfisa_a },
+{"moveml", 4, one(0046300), one(0177700), "ys#w", mcfisa_a },
{"movepw", 2, one(0000410), one(0170770), "dsDd", m68000up },
{"movepw", 2, one(0000610), one(0170770), "Ddds", m68000up },