This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] PowerPC VLE port


On Fri, Apr 20, 2012 at 04:25:07PM -0400, James Lemke wrote:
> +.  {*  Indicate that the section has the VLE bit set. *}
> +.#define SEC_PPC_VLE 0x80000000
> +.

The patch looks good except for this piece.  I can't let you use a bit
in the generic flag space just for PowerPC when I've objected to other
ports doing the same.  You should use one of the available sec_flg
bits instead.  ppc_elf_section_flags will need to be changed to set
hdr->bfd_section->sec_flg<n> directly.  ppc_elf_lookup_section_flags
ought to be setting SHF_PPC_VLE.  The patch is OK with these changes.

Hmm.  Looks to me like INPUT_SECTION_FLAGS is totally broken.
elflink.c:bfd_elf_lookup_section_flags sets SHF_* bits into
not_with_flags and only_with_flags, but ldlang.c:lang_add_section
compares them to section->flags which contains SEC_*.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]