This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold patch] Add --export-dynamic-symbol option

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Mon, 16 Apr 2012 17:30:15 -0700
Subject: Re: [gold patch] Add --export-dynamic-symbol option
References: <CAHACq4qrRSyeGxP8n2mz4nBz2ezuR0w04gYBBXP4D-xy12qMjw@mail.gmail.com> <mcry5pvmdwq.fsf@dhcp-172-18-216-180.mtv.corp.google.com>

> Gold warnings start with lower case letters, so s/Cannot/cannot/.
>
> I wonder if it's really appropriate to call demangled_name here. ?The
> symbol names in --dynamic-list or --export-dynamic-symbol are not
> mangled. ?It will probably be clearer to simply print this->name().

Done.

> This is OK with those changes.

Thanks, committed.

-cary

References:
- [gold patch] Add --export-dynamic-symbol option
  - From: Cary Coutant
- Re: [gold patch] Add --export-dynamic-symbol option
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]