This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Test regressions for arm-eabi from "[PATCH] arm-nacl target support"


Oops.  When I did my regression tests I hadn't nuked ld/tmpdir so I
overlooked these nonobvious order dependencies.  (You may notice that
if you run 'make check' twice, it works the second time.)

I've fixed it with the following change, which I've committed as obvious.
Sorry for the hassle.


Thanks,
Roland


ld/testsuite/
2012-04-13  Roland McGrath  <mcgrathr@google.com>

	* ld-arm/arm-elf.exp (armelftests_common): Move cases using
	mixed-lib.so to ...
	(armelftests_nonacl): ... here.

diff --git a/ld/testsuite/ld-arm/arm-elf.exp b/ld/testsuite/ld-arm/arm-elf.exp
index 1ffe344..05dc7bb 100644
--- a/ld/testsuite/ld-arm/arm-elf.exp
+++ b/ld/testsuite/ld-arm/arm-elf.exp
@@ -154,9 +154,6 @@ set armelftests_common {
     {"BE8 Mapping Symbols" "-static -T arm.ld -EB --be8" "-EB" {arm-be8.s}
      {{objdump -d arm-be8.d}}
      "arm-be8"}
-    {"Using Thumb lib by another lib" "-shared tmpdir/mixed-lib.so"
"" {use-thumb-lib.s}
-     {{readelf -Ds use-thumb-lib.sym}}
-     "use-thumb-lib.so"}
     {"VFP11 denorm erratum fix, scalar operation"
      "-EL --vfp11-denorm-fix=scalar -Ttext=0x8000" "-EL -mfpu=vfpxd"
{vfp11-fix-scalar.s}
      {{objdump -dr vfp11-fix-scalar.d}}
@@ -239,10 +236,6 @@ set armelftests_common {
     {"arm-pic-veneer" "-static -T arm.ld --pic-veneer" "" {arm-pic-veneer.s}
      {{objdump -d arm-pic-veneer.d}}
      "arm-pic-veneer"}
-    {"Preempt Thumb symbol" "tmpdir/mixed-lib.so -T arm-dyn.ld --use-blx" ""
-     {preempt-app.s}
-     {{readelf -Ds preempt-app.sym}}
-     "preempt-app"}
     {"jump19" "-static -T arm.ld" "" {jump19.s}
      {{objdump -dr jump19.d}}
      "jump19"}
@@ -309,6 +302,13 @@ set armelftests_nonacl {
      {{objdump -fdw mixed-app-v5.d} {objdump -Rw mixed-app.r}
       {readelf -Ds mixed-app.sym}}
      "mixed-app-v5"}
+    {"Using Thumb lib by another lib" "-shared tmpdir/mixed-lib.so"
"" {use-thumb-lib.s}
+     {{readelf -Ds use-thumb-lib.sym}}
+     "use-thumb-lib.so"}
+    {"Preempt Thumb symbol" "tmpdir/mixed-lib.so -T arm-dyn.ld --use-blx" ""
+     {preempt-app.s}
+     {{readelf -Ds preempt-app.sym}}
+     "preempt-app"}
     {"TLS gnu shared library inlined trampoline" "--no-fix-arm1176
-shared -T arm-dyn.ld" "" {tls-descseq.s}
      {{objdump -fdw tls-descseq.d} {objdump -Rw tls-descseq.r}}
      "tls-lib2inline.so"}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]