This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATH] gas: .warn and .nowarn pseudo-ops.

From: nick clifton <nickc at redhat dot com>
To: "Smets, Jan (Jan)" <jan dot smets at alcatel-lucent dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
Date: Fri, 30 Mar 2012 13:46:54 +0100
Subject: Re: [PATH] gas: .warn and .nowarn pseudo-ops.
References: <14C7F4F06DB5814AB0DE29716C4F6D6740484571@FRMRSSXCHMBSB1.dc-m.alcatel-lucent.com>

Hi Jan,

I have added pseudo operators to locally disable assembler warnings.

Thank you for the patch. It looks good, but there are a couple of small points which I would like to see addressed:

1. Do you have an FSF binutils copyright assignment ? The patch is quite small, but I do not feel that it counts as "obvious" since it is adding a new feature to the assembler.

2. New features like this ought to be mentioned in the gas/NEWS file.

3. You should also provide a test case for the gas testsuite so that we make sure that the feature continues to work into the future. The test should be architecture agnostic and it should make sure that both the turning off and turning back on of warnings works.

With these points resolved I would be happy to accept the patch.

Cheers
  Nick

Follow-Ups:
- RE: [PATH] gas: .warn and .nowarn pseudo-ops.
  - From: Smets, Jan (Jan)

References:
- [PATH] gas: .warn and .nowarn pseudo-ops.
  - From: Smets, Jan (Jan)

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]