This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] ld: optimize vfinfo output slightly


Mike Frysinger <vapier@gentoo.org> writes:

> +	  size_t len = fmt - str;
> +
> +	  if (fwrite (str, 1, len, fp) != len)
> +	    abort ();

Write errors should either be handled or ignored, but aborting is not
the right thing (it's not an internal error).

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]