This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFA: performance improvement for PowerPC disassembly

On Fri, Mar 16, 2012 at 10:33:39AM -0400, James Lemke wrote:
> table segments.  Wouldn't it be preferable to keep a #define for the
> number of segments versus having 64 or 65 in various places?

I avoided a define because the value can't be changed as you could
with the original implementation.  Incidentally, "various places" is
just two places, the array definition and its initialisation a few
lines later.  I suppose I could have used sizeof in the
initialisation, or #define NUM_MAJOR_OPCODES 64 and used that to add
a little documentation in the code.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]