This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: 68hc11/12/s12x/xgate patch
- From: James Murray <jsm at jsm-net dot demon dot co dot uk>
- To: binutils at sourceware dot org
- Cc: nick clifton <nickc at redhat dot com>
- Date: Sun, 26 Feb 2012 23:54:42 +0000
- Subject: Re: 68hc11/12/s12x/xgate patch
- References: <1298845471.12108.12.camel@jsm2> <1299515895.3262.1.camel@jsm2> <4D7F247D.6070303@redhat.com> <1300201861.20997.3.camel@jsm2> <1324419607.8652.84.camel@jsm2> <CABZhLO-Ye-G1nYW1eqpdjnYG1W4zaKq+TvgzFBebJk4ash5mtg@mail.gmail.com> <1324423375.8652.94.camel@jsm2> <4EF36049.3050802@ipdatasys.com> <CABZhLO_RKXkcKRGH_b-f_iVYppcgBQ3XBf9STWjZeTCwrQJhzQ@mail.gmail.com> <1324575421.2430.42.camel@jsm2> <1325800936.20629.53.camel@jsm2> <4F0C4DFE.4050801@redhat.com>
Status update.
On Tue, 2012-01-10 at 14:41 +0000, nick clifton wrote:
> Hi James,
> *) You have included a patch to the top level configure file, but not
> the top level configure.ac file (from which the configure file is
> generated).
I've removed my changes and used the existing build targets.
> *) You have included a patch to the top level config.sub file. Are you
> aware that this patch needs to be submitted to a different project ?
> (config-patches@gnu.org)
I've removed my changes and used the existing build targets.
> *) You have included patches to various ChangeLogs. Common practice is
> just to include changelog entries as plain text, since they almost never
> apply cleanly as patches.
Ready to submit as plain text.
> *) You have added new options to the m68hc11 GAS port, but not added
> documentation for these new options to the gas/doc/c-m68hc11.texi file.
OK, added.
> *) You have added support for a new processor, but not mentioned it in
> either gas/NEWS or ld/NEWS.
OK, added.
> *) There are some formatting problems. Ideally we like code that
> follows the GNU Coding Standard: http://www.gnu.org/prep/standards/
Understood and hopefully now addressed.
I intend to spend some more time reviewing my patch and will re-submit
once I have completed that.
regards
James Murray