RE: [MIPS] Add saa and saad instructions for octeon

[<Paul_Koning at Dell dot com>]

>Richard Sandiford <rdsandiford@googlemail.com> writes:
>> Andrew Pinski <andrew.pinski@caviumnetworks.com> writes:
>>> Hi,
>>>   This patch adds the saa and saad instructions for Octeon.   They are
>>> not part of the original Octeon but are part of the Octeon+.  We at 
>>> Cavium don't feel the need to add a new arch for it since this is the 
>>> only difference instruction wise and the original Octeon is no longer 
>>> in production.
>>
>> I think it's still worth having a separate CPU name for it.
>
>and (to be clear) CPU enum, so that the instructions can be rejected for plain -march=octeon.

I agree.  If they were added in octeonplus then they should show up if you select that arch.  The issue isn't if the original chip is in current production; it matters that it was in production at some point in the past and people might have one.  Otherwise we would end up with Pentium instructions showing up if you say -march=i386...

	paul