This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] PR gold/13023: Fix problem with assignments to dot in linker scripts
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Mon, 31 Oct 2011 14:17:46 -0700
- Subject: Re: [gold patch] PR gold/13023: Fix problem with assignments to dot in linker scripts
- References: <CAHACq4pP=Nk3v2ncW7voRFP9od+1f0CSe6X_ZU_oOezXHSx2ig@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> PR gold/13023
> * expression.cc (Expression::eval_with_dot): Add
> is_section_dot_assignment parameter.
> (Expression::eval_maybe_dot): Likewise. Adjust value when rhs is
> absolute and assigning to dot within a section.
> * script-sections.cc
> (Output_section_element_assignment::set_section_addresses): Pass
> dot_section to set_if_absolute.
> (Output_section_element_dot_assignment::finalize_symbols): Pass TRUE
> as is_section_dot_assignment flag to eval_with_dot.
> (Output_section_element_dot_assignment::set_section_addresses):
> Likewise.
> * script.cc (Symbol_assignment::set_if_absolute): Add dot_section
> parameter. Also set value if relative to dot_section; set the
> symbol's output_section.
> * script.h (Expression::eval_with_dot): Add is_section_dot_assignment
> parameter. Adjust all callers.
> (Expression::eval_maybe_dot): Likewise.
> (Symbol_assignment::set_if_absolute): Add dot_section parameter.
> Adjust all callers.
> * testsuite/script_test_2.t: Test assignment of an absolute value
> to dot within an output section element.
This is OK.
Thanks.
Ian