Re: [gold patch] Add incremental link support for debug sections

[Ian Lance Taylor <iant at google dot com>]

Cary Coutant <ccoutant@google.com> writes:

>> Â Â Â Â* gold/layout.cc (Free_list::allocate): Provide guarantee of minimum
>> Â Â Â Âremaining hole size when allocating.
>> Â Â Â Â(Layout::make_output_section): Set fill methods for debug sections.
>> Â Â Â Â* gold/layout.h (Free_list::Free_list_node): Move from private to
>> Â Â Â Âpublic.
>> Â Â Â Â(Free_list::set_min_hole_size): New function.
>> Â Â Â Â(Free_list::begin, Free_list::end): New functions.
>> Â Â Â Â(Free_list::min_hole_): New data member.
>> Â Â Â Â* gold/output.cc: Include dwarf.h.
>> Â Â Â Â(Output_fill_debug_info::do_minimum_hole_size): New function.
>> Â Â Â Â(Output_fill_debug_info::do_write): New function.
>> Â Â Â Â(Output_fill_debug_line::do_minimum_hole_size): New function.
>> Â Â Â Â(Output_fill_debug_line::do_write): New function.
>> Â Â Â Â(Output_section::Output_section): Initialize new data member.
>> Â Â Â Â(Output_section::set_final_data_size): Ensure patch space is larger
>> Â Â Â Âthan minimum hole size.
>> Â Â Â Â(Output_section::do_write): Fill holes in debug sections.
>> Â Â Â Â* gold/output.h (Output_fill): New class.
>> Â Â Â Â(Output_fill_debug_info): New class.
>> Â Â Â Â(Output_fill_debug_line): New class.
>> Â Â Â Â(Output_section::set_free_space_fill): New function.
>> Â Â Â Â(Output_section::free_space_fill_): New data member.
>> Â Â Â Â* gold/testsuite/Makefile.am (incremental_test_3): Add
>> Â Â Â Â--incremental-patch option.
>> Â Â Â Â(incremental_test_4): Likewise.
>> Â Â Â Â(incremental_test_5): Likewise.
>> Â Â Â Â(incremental_test_6): Likewise.
>> Â Â Â Â(incremental_copy_test): Likewise.
>> Â Â Â Â(incremental_common_test_1): Likewise.
>> Â Â Â Â* gold/testsuite/Makefile.in: Regenerate.


> +class Output_fill
> +{
> + public:
> +  Output_fill()
> +  { this->is_big_endian_ = parameters->target().is_big_endian(); }

Why not just write
    : is_big_endian_(parameters->target().is_big_endian())
  { }


This is OK with or without that change.

Thanks.

Ian