This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch] Allow an ET_EXEC file with the --just-symbols/-R option
- From: Ian Lance Taylor <iant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Fri, 29 Jul 2011 18:16:20 -0700
- Subject: Re: [gold patch] Allow an ET_EXEC file with the --just-symbols/-R option
- References: <CAHACq4pk9dyae4p35cPy8avbQSrQffCQN++5YYU1rK1vC-HLnw@mail.gmail.com>
Cary Coutant <ccoutant@google.com> writes:
> * layout.cc (Layout::set_segment_offsets): Don't realign text
> segment if -Ttext was specified.
> * object.cc (Sized_relobj_file::Sized_relobj_file): Store the ELF
> file type.
> * object.h (Sized_relobj_file::e_type): New function.
> (Sized_relobj_file::e_type_): New data member.
> * symtab.cc (Symbol_table::add_from_relobj): Don't add section
> base address for ET_EXEC files.
> * target.cc (Target::do_make_elf_object_implementation): Allow
> ET_EXEC files with --just-symbols option.
> - if (orig_st_shndx != elfcpp::SHN_UNDEF && is_ordinary)
> + if (orig_st_shndx != elfcpp::SHN_UNDEF && is_ordinary
> + && relobj->e_type() == elfcpp::ET_REL)
Move the && from the middle of the line to the start of a new
line--i.e., three lines in the condition, the last two starting with
&&.
This is OK with that change.
Thanks.
Ian