Re: [gold patch] Incremental 15/18: Add --incremental-base option.

[Cary Coutant <ccoutant at google dot com>]

> This patch adds a --incremental-base option, so that the base file for
> the incremental link can be different from the output file. For
> simplicity, I simply copy the base file contents to a new output file,
> then carry on with a normal incremental link.

This patch tried to open the base file for writing, and some of the
error messages would give the wrong file name. Here's a replacement
patch...

-cary


	* gold.cc (queue_initial_tasks): Pass incremental base filename
	to Output_file::open_base_file; don't print error message.
	* incremental-dump.cc (main): Adjust call to
	Output_file::open_for_modification.
	* incremental-dump.cc (main): Likewise.
	* incremental.cc (Incremental_inputs::report_command_line):
	Ignore --incremental-base option when comparing command lines.
	* options.h (class General_options): Add --incremental-base.
	* output.cc (Output_file::Output_file):
	(Output_file::open_base_file): Add base_name and writable parameters;
	copy base file to new file; print error message here.
	(Output_file::map_no_anonymous): Add writable parameter; adjust all
	callers.
	* output.h (Output_file::open_for_modification): Rename to...
	(Output_file::open_base_file): ...this; add base_name and
	writable parameters; adjust all callers.
	(Output_file::map_no_anonymous): Add writable parameter; adjust all
	callers.
	* testsuite/Makefile.am (incremental_test_4): Test
	--incremental-base.
	* testsuite/Makefile.in: Regenerate.

Attachment: incr-patch-15b.txt
Description: Text document