This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GAS/ARM] Better handling of difference between a symbol and an undefined symbol.
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 17 Mar 2011 12:35:55 +1030
- Subject: Re: [PATCH][GAS/ARM] Better handling of difference between a symbol and an undefined symbol.
- References: <4CA132F7.8020803@gmail.com> <AANLkTi=LnBj7U9V3PCrtUCoHj0QPV6d2VAKOwWJMw9T9@mail.gmail.com> <4CA1465D.30105@gmail.com> <AANLkTimewc4r=wh=ACmMJYkNgHcaiYWjM_Qe8xL+LKo2@mail.gmail.com> <AANLkTimpYE-k0c+LC2_AjgrGJ4XNRLypfSEYENU=jr4X@mail.gmail.com> <4CA1682D.8080500@gmail.com> <20100928041456.GU16376@bubble.grove.modra.org> <AANLkTinddt6Or0wcCN3Gh4U22C4QzwYoBDXA0S_CH3n6@mail.gmail.com> <20100929064955.GY16376@bubble.grove.modra.org> <AANLkTinnTc_Fathg_7SEhACBae3qNA8+ZoMPOmXJ-18e@mail.gmail.com>
On Wed, Mar 16, 2011 at 02:31:44PM -0700, H.J. Lu wrote:
> On Tue, Sep 28, 2010 at 11:49 PM, Alan Modra <amodra@gmail.com> wrote:
> > gas/
> > ? ? ? ?* expr.c (expr): Correct returned segment value.
> > gas/testsuite/
> > ? ? ? ?* gas/all/fwdexp.d, * gas/all/fwdexp.s: New test.
> > ? ? ? ?* gas/all/gas.exp: Run it.
>
> This caused:
>
> http://www.sourceware.org/bugzilla/show_bug.cgi?id=12589
I think the above patch is correct. Do you see a problem with it?
What it does do is expose other bugs in gas, in this case that
read.c:pseudo_set throws away the correct segment returned from expr()
and instead replaces it with expr_section. Trouble is, looks like
using the correct segment there exposes yet more problems.
--
Alan Modra
Australia Development Lab, IBM