This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/12356: [Regression] x86_64 kernel failed to link
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 10 Feb 2011 18:33:43 +1030
- Subject: Re: PATCH: PR ld/12356: [Regression] x86_64 kernel failed to link
- References: <20110113171002.GA19795@intel.com>
On Thu, Jan 13, 2011 at 09:10:02AM -0800, H.J. Lu wrote:
> 2011-01-13 H.J. Lu <hongjiu.lu@intel.com>
>
> PR ld/12356
> * ld-scripts/defined.exp: Run defined5.
>
> * ld-scripts/defined5.d: New.
> * ld-scripts/defined5.s: Likewise.
> * ld-scripts/defined5.t: Likewise.
This one didn't even assemble on AOUT targets due to lack of .section,
and broke on COFF targets due to limitation in section name length.
AOUT targets still fail after fixing the assembly problem since the
format doesn't really allow arbitrary section addresses, so disable
the test entirely for AOUT.
* ld-scripts/defined.exp: Don't run defined5 for AOUT.
* ld-scripts/defined5.s: Use .text for "defined" section.
* ld-scripts/defined5.t: Adjust.
Index: ld/testsuite/ld-scripts/defined5.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/defined5.s,v
retrieving revision 1.1
diff -u -p -r1.1 defined5.s
--- ld/testsuite/ld-scripts/defined5.s 13 Jan 2011 17:07:52 -0000 1.1
+++ ld/testsuite/ld-scripts/defined5.s 10 Feb 2011 04:00:31 -0000
@@ -1,6 +1,6 @@
.globl defined
.data
.byte 0
- .section .data.cacheline_aligned
+ .text
defined:
.byte 0
Index: ld/testsuite/ld-scripts/defined5.t
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/defined5.t,v
retrieving revision 1.1
diff -u -p -r1.1 defined5.t
--- ld/testsuite/ld-scripts/defined5.t 13 Jan 2011 17:07:52 -0000 1.1
+++ ld/testsuite/ld-scripts/defined5.t 10 Feb 2011 04:00:31 -0000
@@ -1,6 +1,6 @@
defined = addr1;
SECTIONS {
- .data.cacheline_aligned : { *(.data.cacheline_aligned) }
+ .text : { *(.text) }
. = ALIGN (0x1000);
.data : { *(.data) }
addr1 = ADDR (.data);
Index: ld/testsuite/ld-scripts/defined.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/defined.exp,v
retrieving revision 1.13
diff -u -p -r1.13 defined.exp
--- ld/testsuite/ld-scripts/defined.exp 13 Jan 2011 17:07:52 -0000 1.13
+++ ld/testsuite/ld-scripts/defined.exp 10 Feb 2011 07:53:14 -0000
@@ -67,5 +67,7 @@ set prms_id 0
run_dump_test "defined2"
run_dump_test "defined3"
run_dump_test "defined4"
-run_dump_test "defined5"
+if ![is_aout_format] {
+ run_dump_test "defined5"
+}
set LDFLAGS "$saved_LDFLAGS"
--
Alan Modra
Australia Development Lab, IBM