Re: [PATCH] Fix objdump output of R_SPARC_OLO10

[David Miller <davem at davemloft dot net>]

From: Alan Modra <amodra@gmail.com>
Date: Fri, 21 Jan 2011 19:26:49 +1030

> On Thu, Jan 20, 2011 at 11:50:11PM -0800, David Miller wrote:
>> 466 lines of code deleted from the tree as a result.
> 
> And a 20% blowout in reloc size.  I can't say I like that.  Well, to
> be fair, this really only matters in the linker and not all backend
> linkers use arelent to handle relocs.  Still, many do, even some ELF
> linkers.

Understood.

Please also note that the majority of the code that gets removed from
bfd/elf??-sparc.c is duplicated code from the generic elf BFD support.

Every time a bug fix goes into generic BFD ELF code a serious
possibility exists that the fix won't propagate into the copies that
exist in various individual ELF targets.

Happily, most of the time developers handle this properly, but the
situation we have right now with this kind of code duplication is
asking for trouble.

Thanks.