This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Bug fix for gldelf_i386_place_orphan in elf32.em [version 2.20.1]
- From: Alan Modra <amodra at gmail dot com>
- To: "Sheng, Yongjie" <yongjie dot sheng at intel dot com>
- Cc: "binutils at sources dot redhat dot com" <binutils at sources dot redhat dot com>
- Date: Wed, 12 Jan 2011 18:08:42 +1030
- Subject: Re: Bug fix for gldelf_i386_place_orphan in elf32.em [version 2.20.1]
- References: <6E3BC7F7C9A4BF4286DD4C043110F30B3B5EA6CBEC@shsmsx502.ccr.corp.intel.com>
On Wed, Jan 12, 2011 at 03:01:15PM +0800, Sheng, Yongjie wrote:
> The above code set the hold[orphan_nonalloc] name as ".comment", but os as lookup->prev. It should be lookup itself, right?
No. The idea is to place orphan non-alloc sections before debug
sections, or when there are no debug sections, before .comment.
The setting of .name is really just to ensure we don't call
output_rel_find later in case no debug or .comment sections exist.
(".comment" is a good choice because we know that won't be found by
lang_output_section_find either.)
--
Alan Modra
Australia Development Lab, IBM