This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bug fix for gldelf_i386_place_orphan in elf32.em [version 2.20.1]


On Wed, Jan 12, 2011 at 03:01:15PM +0800, Sheng, Yongjie wrote:
> The above code set the hold[orphan_nonalloc] name as ".comment", but os as lookup->prev. It should be lookup itself, right?

No.  The idea is to place orphan non-alloc sections before debug
sections, or when there are no debug sections, before .comment.

The setting of .name is really just to ensure we don't call
output_rel_find later in case no debug or .comment sections exist.
(".comment" is a good choice because we know that won't be found by
lang_output_section_find either.)

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]