Re: [PATCH 13/20] MIPS/GAS: Improve instruction's mnemonic processing

["Maciej W. Rozycki" <macro at codesourcery dot com>]

On Sat, 11 Dec 2010, Richard Sandiford wrote:

> > 	* config/tc-mips.c (mips_ip): Make a copy of the instruction's
> > 	mnemonic and use it for further processing.
> 
> OK as part of the microMIPS patch.

 That's not going to be a problem -- `quilt' makes such patch shuffling, 
folding, etc. quite easy. :)

> (In case you're wondering why not just "OK": there's nothing wrong with
> temporarily replacing whitespace with nulls, so without the microMIPS
> changes, that's what we'd do here.  The thing I objected to with the
> microMIPS patch was editing the mnemonic in-place, by removing characters.
> That's what you're fixing with the combination of this patch and the
> updated microMIPS one, so the two patches are OK together.)

 I find it a bit hackish, especially as code has to be written carefully 
to replace the original character at return points as needed (currently 
three of the seven do so; the exact requirement pattern seems unobvious to 
me -- is it any clearer to you?), but not particularly incorrect.

  Maciej