Re: [PATCH] Fix binutils/gold build on NetBSD

[Arnaud Lacombe <lacombar at gmail dot com>]

Hi,

On Mon, Dec 6, 2010 at 6:26 PM, Ian Lance Taylor <iant@google.com> wrote:
> Arnaud Lacombe <lacombar@gmail.com> writes:
>
>> This patch intends to fix gold build on NetBSD host. NetBSD supports mremap(2),
>> but does not support MREMAP_MAYMOVE flags.
>>
>> This patch renames gold's internal version of mremap to avoid namespace conflict
>> as prototypes differs and add an additionnal configure-time check for
>> MREMAP_MAYMOVE.
>
> I would prefer to avoid adding the #ifdef to output.cc. ?Also, the
> configure check should be cached. ?Does this patch work for you?
>
I did not test it yet, but I would expect it to work. I will confirm
that later on.

In the mean time, shouldn't this kind of portability call go to libiberty ?

Thanks,
 - Arnaud