This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH 20/20] MIPS/GAS: Remove dead format specifier code
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: Catherine Moore <clm at codesourcery dot com>, binutils at sourceware dot org
- Date: Thu, 2 Dec 2010 19:24:44 +0000 (GMT)
- Subject: [PATCH 20/20] MIPS/GAS: Remove dead format specifier code
Hi,
This change removes unreachable code -- at this point c may only be one
of: 'b', 'd', 's', 't', 'r', 'v', 'w', 'E', 'K', 'x', 'z', 'U' or 'g' as
selected by the switch case this piece of code is contained within. This
observation also invalidates the comment included -- given the limited set
of choices as quoted above c cannot contain "other operands like 'i'."
2010-12-02 Maciej W. Rozycki <macro@codesourcery.com>
gas/
* config/tc-mips.c (mips_ip): Remove dead format specifier code.
OK to apply?
Maciej
binutils-gas-mips-ip-reg-dead.diff
Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2010-12-01 21:05:59.000000000 +0000
+++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2010-12-01 21:05:59.000000000 +0000
@@ -9506,7 +9506,6 @@ mips_ip (char *str, struct mips_cl_insn
INSERT_OPERAND (RS, *ip, regno);
break;
case 'd':
- case 'G':
case 'K':
case 'g':
INSERT_OPERAND (RD, *ip, regno);
@@ -9535,11 +9534,6 @@ mips_ip (char *str, struct mips_cl_insn
is $0. This only matches $0, and is checked
outside the switch. */
break;
- case 'D':
- /* Itbl operand; not yet implemented. FIXME ?? */
- break;
- /* What about all other operands like 'i', which
- can be specified in the opcode table? */
}
lastregno = regno;
continue;