This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS/GAS: Fix NewABI reloc handling with the LD/SD macro
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>
- Cc: binutils at sourceware dot org
- Date: Mon, 01 Nov 2010 08:45:18 +0000
- Subject: Re: [PATCH] MIPS/GAS: Fix NewABI reloc handling with the LD/SD macro
- References: <alpine.LFD.2.00.1010241201020.15889@eddie.linux-mips.org> <87wrp6m03j.fsf@firetop.home> <alpine.LFD.2.00.1010311914200.25426@eddie.linux-mips.org>
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> On Mon, 25 Oct 2010, Richard Sandiford wrote:
>> This may be a known bug, and is certainly nothing to do with your patches,
>> but I notice:
>>
>> ld $4,0x7ffc($5)
>>
>> fails to work correctly (or trigger a diagnostic) in o32 mode.
>> 0x8000 works fine of course.
>
> You didn't like my patch addressing this issue back here:
>
> http://sourceware.org/ml/binutils/2005-02/msg00610.html
>
> (originally here: http://sourceware.org/ml/binutils/2004-06/msg00530.html)
>
> but I've kept maintaining it locally over the years (and got it up to
> 2.20; obviously with the recent changes it'll require an update, but I
> planned to do that anyway while upgrading the RPM packages I maintain).
> If you'd like me to get it refreshed and resubmitted, then I am all for
> it.
No, I stand by what I said there. IMO the reloc case isn't interesting
for the reasons discussed in that thread. The o(b) case _is_
interesting because it is inconsistent with the corresponding
o(b) behaviour for unaligned loads and stores.
Richard