This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix testsuite ldscripts problem


* Dave Korn wrote on Wed, Oct 27, 2010 at 10:43:19PM CEST:
> On 27/10/2010 19:22, Ralf Wildenhues wrote:
> > * Dave Korn wrote on Wed, Oct 27, 2010 at 01:37:26AM CEST:
> >> On 26/10/2010 21:22, Ralf Wildenhues wrote:
> >>> Besides, Solaris /bin/sh test does not have -e, so you might want to
> >>> prefer -f or -r if you're still going to use the test.
> >>   Surely -f isn't right?  I think that checks for a regular file, and I do not
> >> know whether a link would necessarily count as one.
> > 
> > If the link points to a regular file, then yes.
> 
>   Actually it points to a directory, so perhaps not?

Right; see below.

> > Since you link to a directory (sorry for not realizing this sooner),
> 
>   Heh!
> 
> > $(LN_S) won't work anyway if it's not 'ln -s', so at that point you'd
> > probably have to mkdir and cp -p or cp -R anyway.  test -d should
> > otherwise work also for symlinks to directories.
> 
>   I thought the whole point of $(LN_S) was that it would turn into a copy on
> platforms like mingw?

Right; but $(LN_S) really only is applicable to regular files, not
directories.  I wouldn't see how to easily abstract away both within
one command.

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]