This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [MIPS] Change madd/maddu/msub/msubu/mult/multu to DSP rev1
Richard Sandiford wrote:
> "Fu, Chao-Ying" <fu@mips.com> writes:
> > Opcodes/ChangeLog
> > 2010-10-20 Chao-ying Fu <fu@mips.com>
> >
> > * mips-opc.c (madd, maddu, msub, msubu, mult,
> multu): Change D33 to D32.
> >
> > Gas/testsuite/ChangeLog
> > 2010-10-20 Chao-ying Fu <fu@mips.com>
> >
> > * gas/mips/mips32-dsp.d, gas/mips/mips32-dsp.s: Add
> madd, maddu, msub, msubu, mult, multu.
>
> Nit: last changelog line needs to be wrapped to 80 chars.
> Otherwise OK,
> thanks.
I updated the ChangeLog to have two lines and committed the patch.
Thanks for your review!
>
> For the record, I did wonder whether we should also remove
> the corresponding
> tests from mips-dspr2.s, since other rev1 stuff isn't tested
> in mips-dspr2.s.
> I agree it's better to leave them though, so that we have
> both classifications
> covered.
Either way is fine with me.
FYI. I will update GCC to support these instructions in DSP r1. Thanks!
Regards,
Chao-ying