This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/GAS/test: Assorted ECOFF fixes


On Sun, 10 Oct 2010, Richard Sandiford wrote:

> > 	gas/testsuite/
> > 	* gas/mips/at-1.d: Handle ECOFF relocations.
> > 	* gas/mips/eret-1.d: Handle ECOFF.
> > 	* gas/mips/eret-2.d: Likewise.
> > 	* gas/mips/eret-3.d: Likewise.
> > 	* gas/mips/lb.d: Handle an ECOFF addend.
> > 	* gas/mips/mips.exp: Only run "aent" for ELF.
> 
> Everything apart from the lb.d change is OK.  I think an ecoff@ override
> is more appropriate for the lb.d test.

 This is exactly the same situation as with ld.d and I'd prefer to take 
the same approach especially as here we should be able to avoid any ECOFF 
overrides at all.  I've taken the change out so as the failure keeps 
sticking out as a reminder even though it only made the single remaining 
offset consistent with the rest.  I have applied the rest of the changes, 
thanks.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]