This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Add plugin interface to LD [3/4] Get symbols and resolutions.
- From: Richard Henderson <rth at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 06 Oct 2010 15:28:48 -0700
- Subject: Re: [PATCH] Add plugin interface to LD [3/4] Get symbols and resolutions.
- References: <4C9AE5CA.80707@gmail.com> <4C9AE64E.3040002@gmail.com>
On 09/22/2010 10:31 PM, Dave Korn wrote:
> + if (blhe->type == bfd_link_hash_common)
> + {
> + /* Is this right? The COMMON section only exists in the
> + output file, so it seems reasonable. */
> + syms[n].resolution = LDPR_RESOLVED_EXEC;
> + continue;
Common symbols can be exported or not exported when generating a
shared library. Another check is needed here. In fact, I don't
see that you're doing any shared library preemption checking in
this function.
... that said, all that is elf-only; windows doesn't do library
symbol preemption.
> + /* Suppresses "unused" warnings without relying on GCC attribute. */
> + info = info;
> + value = value;
Er, I presume this is going away in a future patch?
r~