This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: objdump infinite loop on v850 object file
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Lee Moore <moore at imperas dot com>
- Cc: binutils at sourceware dot org
- Date: Tue, 05 Oct 2010 20:17:18 +0200
- Subject: Re: objdump infinite loop on v850 object file
- References: <4ca9bbac.cbb1e30a.4ea2.ffffb10d@mx.google.com> <20101005053325.GJ16376@bubble.grove.modra.org>
Alan Modra <amodra@gmail.com> writes:
> Index: binutils/bucomm.c
> ===================================================================
> RCS file: /cvs/src/src/binutils/bucomm.c,v
> retrieving revision 1.39
> diff -u -p -r1.39 bucomm.c
> --- binutils/bucomm.c 11 Dec 2009 13:42:05 -0000 1.39
> +++ binutils/bucomm.c 5 Oct 2010 03:07:22 -0000
> @@ -52,8 +52,10 @@ char *program_name;
> void
> bfd_nonfatal (const char *string)
> {
> - const char *errmsg = bfd_errmsg (bfd_get_error ());
> + const char *errmsg;
>
> + fflush (stdout);
> + errmsg = bfd_errmsg (bfd_get_error ());
Wouldn't that clobber errno if the error is bfd_error_system_call?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."