This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[GOLD][PATCH] Fix bug in handling GOT entry of an undefined symbol.


Hi,

    This fixes a problem in which Target_arm::Relocate::relocate exits
early if there is a GOT-using relocation of an undefined global
symbol.  The current code just assumes that it is an error and exit.
For relocation types using GOT entries, it does not matter if the
symbol is defined or not and what kind the symbol is.  So we should
skip the the tests.  The patch also fixes two safe ICF related tests,
which expect only x86 to be able to do safe ICF.   The ARM back-end is
capable of doing safe ICF using relocation types.  So these tests need
to be adjusted for ARM.

-Doug

2010-09-17  Doug Kwan  <dougkwan@google.com>

        * arm.cc (Target_arm::Relocate::relocate): Ignore symbol type and
        defintion if relocation uses GOT entries of the symbol.
        * testsuite/icf_safe_test.sh: Fix test.
        * testsuite/icf_safe_so_test.sh: Fix test.

Attachment: patch-got.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]