This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] objcopy: add an interleave width parameter to objcopy
- From: Nick Clifton <nickc at redhat dot com>
- To: Ben Gardiner <bengardiner at nanometrics dot ca>
- Cc: binutils at sourceware dot org, "William A. Gatliff" <bgat at billgatliff dot com>, Wayne Young <wayne dot young at honeywell dot com>
- Date: Fri, 10 Sep 2010 13:16:24 +0100
- Subject: Re: [PATCH] objcopy: add an interleave width parameter to objcopy
- References: <1281923474-28927-1-git-send-email-bengardiner@nanometrics.ca>
Hi Ben,
Add a width parameter to objcopy that can be used in concert with -b and
-i to produced binary images for 16-bit interleaved flashes.
Thanks for submitting this enhancement. Normally we would requite a FSF
Binutils copyright assignment before we could accept the code, but since
the core of the change is so small, I have decided to accept it as an
"obvious change".
I have checked your patch in with one change - I altered the name of the
new option from --width to --interleave-width. I felt that --width on
its own was too generic and might confuse people unfamiliar with the
interleaving options to objcopy. I also took the trouble to reword the
description of the interleaving switches in the binutils.texi file, as I
felt that it was a little hard to understand in its former state.
I also created two changelog entries for your patch (see below).
Normally these would be produced by you when you submit the patch.
Cheers
Nick
binutils/ChangeLog
2010-09-10 Ben Gardiner <bengardiner@nanometrics.ca>
* objcopy.c: Add --interleave-width option to allow interleaving
of more than one byte at a time.
(copy_width): New variable.
(copy_options): Add --interleave-width.
(copy_section): When interleaving copy in units of copy_width
bytes.
(copy_main): Parse the new option.
* doc/binutils: Document the new option.
* NEWS: Mention the new feature.
binutils/testsuite/ChangeLog
2010-09-10 Ben Gardiner <bengardiner@nanometrics.ca>
* binutils-all/objcopy.exp: Add test of new --interleave-width
option.