This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Use correct local symbol values in stub generation.
在 2010年9月8日上午8:03,Ian Lance Taylor <iant@google.com> 寫道:
> The indentation looks wrong here.
Will fix that.
> This interface seems overly complicated, because of the way it changes
> *lv. A local symbol value is represented in two values: a number and a
> Merged_symbol_value. Can you change this function to take a const
> Symbol_value pointer and to return those two values?
I originally thought of that too but there are cases in which the
symbol is left untouched. So I picked the current interface.
compute_final_local_value() leaves the local symbol unmodified when
return value != CFLV_OK, I guess I can change the interface with two
pointers, one for input and one for output and the output value to be
undefined when return value != CFLV_OK. We will still preserve some
undocumented behaviours for return values != CFLV_OK so that
do_finalize_local_symbols has the same behaviour.
> Also I'm not sure the internal and external functions should have the
> same name.
Will rename one of them to make them different.
> Also there should be a space after Symbol_value<size>*.
Ok.
I will send out a new patch soon. Thanks for reviewing.
-Doug