This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: ld/11944: elf_object_id (abfd) == elf_hash_table_id (htab) dosn't work on all targets

On Wed, 25 Aug 2010, H.J. Lu wrote:

> > ? ? ? ?* elf64-mips.c (ELF_TARGET_ID): New.
[...]
> > ? ? ? ?* elfn32-mips.c (ELF_TARGET_ID): New.
[...]
> I will check it to fix many ELF targets if there are no objections.

 No opinion as to the update itself, but changes corresponding to the 
ChangeLog entries above are missing from your patch.

 Also elfxx-mips.h might be the right place to put macro definitions 
shared across all the MIPS ELF variants; just a side note -- not that you 
should be doing that with your proposed change.

  Maciej
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]