This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS/LD: Fix up testsuite breakage from gettextisation
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, binutils at sourceware dot org
- Date: Fri, 20 Aug 2010 19:38:08 +0100 (BST)
- Subject: Re: [PATCH] MIPS/LD: Fix up testsuite breakage from gettextisation
- References: <alpine.DEB.1.10.1008170108000.4295@tp.orcam.me.uk> <4C6A5B77.5090507@redhat.com>
Hi Nick,
> > While the changes to the messages might have been legitimate (what was the
> > reason behind them BTW? -- I don't find the new ones any better than the
> > old ones),
>
> The reason was that the output was referring to command line options that are
> specific to GCC, which I felt was incompatible with readelf's mission to work
> with any ELF binary, regardless of which compiler produced it.
I can see your point. While the mention of GCC options is good for
newbies, it's not neutral as such a tool should be and all the world is
not GCC (even if we try hard ;) ). Documentation is where such
peculiarites should be made known to the outside world; regrettably I
don't think we're particularly good at documenting various GNU and other
extensions.
But we should stay consistent then, shouldn't we?
2010-08-20 Maciej W. Rozycki <macro@codesourcery.com>
binutils/
* readelf.c (display_mips_gnu_attribute): Replace GCC options
with a textual description of a MIPS32r2 64-bit FPU.
ld/testsuite/
* ld-mips-elf/attr-gnu-4-04.d: Adjust Tag_GNU_MIPS_ABI_FP for
the new MIPS32r2 64-bit FPU description.
* ld-mips-elf/attr-gnu-4-40.d: Likewise.
* ld-mips-elf/attr-gnu-4-44.d: Likewise.
OK for this change?
Maciej
binutils-fsf-2.20.51-20100819-readelf-mips32r2-fpu-0.patch
Index: binutils-fsf-trunk-quilt/binutils/readelf.c
===================================================================
--- binutils-fsf-trunk-quilt.orig/binutils/readelf.c 2010-07-28 22:41:04.000000000 +0100
+++ binutils-fsf-trunk-quilt/binutils/readelf.c 2010-08-20 17:38:22.000000000 +0100
@@ -10640,7 +10640,7 @@ display_mips_gnu_attribute (unsigned cha
printf (_("Soft float\n"));
break;
case 4:
- printf (_("64-bit float (-mips32r2 -mfp64)\n"));
+ printf (_("Hard float (MIPS32r2 64-bit FPU)\n"));
break;
default:
printf ("??? (%d)\n", val);
Index: binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-04.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/ld/testsuite/ld-mips-elf/attr-gnu-4-04.d 2010-05-12 22:06:11.000000000 +0100
+++ binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-04.d 2010-08-20 17:53:02.000000000 +0100
@@ -7,4 +7,4 @@
Attribute Section: gnu
File Attributes
- Tag_GNU_MIPS_ABI_FP: 64-bit float \(-mips32r2 -mfp64\)
+ Tag_GNU_MIPS_ABI_FP: Hard float \(MIPS32r2 64-bit FPU\)
Index: binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-40.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/ld/testsuite/ld-mips-elf/attr-gnu-4-40.d 2010-05-12 22:06:08.000000000 +0100
+++ binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-40.d 2010-08-20 17:53:09.000000000 +0100
@@ -7,4 +7,4 @@
Attribute Section: gnu
File Attributes
- Tag_GNU_MIPS_ABI_FP: 64-bit float \(-mips32r2 -mfp64\)
+ Tag_GNU_MIPS_ABI_FP: Hard float \(MIPS32r2 64-bit FPU\)
Index: binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-44.d
===================================================================
--- binutils-fsf-trunk-quilt.orig/ld/testsuite/ld-mips-elf/attr-gnu-4-44.d 2010-05-12 22:06:10.000000000 +0100
+++ binutils-fsf-trunk-quilt/ld/testsuite/ld-mips-elf/attr-gnu-4-44.d 2010-08-20 17:53:12.000000000 +0100
@@ -7,4 +7,4 @@
Attribute Section: gnu
File Attributes
- Tag_GNU_MIPS_ABI_FP: 64-bit float \(-mips32r2 -mfp64\)
+ Tag_GNU_MIPS_ABI_FP: Hard float \(MIPS32r2 64-bit FPU\)